[Davical-general] Reviewing status of Ján's patches

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Davical-general] Reviewing status of Ján's patches

Andrew Ruthven
Hey,

After seeing that there has been some recent activity, I thought I'd
have a look at the set of patches that Ján has available[0].

It appears that some have been applied to DAViCal, but some haven't.
These have been:

XMLElement.php.diff
caldav-REPORT.php-privacy_and_alarm.diff
caldav-REPORT.php.diff
collection-edit.php.diff

But these haven't been:

DAVPrincipal.php_active_delegate.diff
auth-functions.php-new.diff
caldav_functions.sql-delete_and_update-fix.diff
hide_older_than_fix.diff
hide_todo_with_useragent_extension.diff

For this one can't, the source file has changed:

vComponent.php.diff

For the ones that haven't been applied, they look legit to me, does
anyone have any concerns about them being applied (apart from lack of
test cases!)

Cheers!

[0] http://www.inf-it.com/davical/

--
Andrew Ruthven
Wellington, New Zealand
At home: [hidden email] |     linux.conf.au 2014
                           | Come swan on the Swan River
                           |    http://linux.conf.au

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Davical-general mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/davical-general

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Reviewing status of Ján's patches

Andrew Ruthven
Right, no complaints, and Andrew M was happy, so I've just committed and
pushed the outstanding patches to github.

On Thu, 2013-09-19 at 21:03 +1200, Andrew Ruthven wrote:

> Hey,
>
> After seeing that there has been some recent activity, I thought I'd
> have a look at the set of patches that Ján has available[0].
>
> It appears that some have been applied to DAViCal, but some haven't.
> These have been:
>
> XMLElement.php.diff
> caldav-REPORT.php-privacy_and_alarm.diff
> caldav-REPORT.php.diff
> collection-edit.php.diff
>
> But these haven't been:
>
> DAVPrincipal.php_active_delegate.diff
> auth-functions.php-new.diff
> caldav_functions.sql-delete_and_update-fix.diff
> hide_older_than_fix.diff
> hide_todo_with_useragent_extension.diff
>
> For this one can't, the source file has changed:
>
> vComponent.php.diff
>
> For the ones that haven't been applied, they look legit to me, does
> anyone have any concerns about them being applied (apart from lack of
> test cases!)
>
> Cheers!
>
> [0] http://www.inf-it.com/davical/
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
> _______________________________________________ Davical-general mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/davical-general
--
Andrew Ruthven
Wellington, New Zealand
At home: [hidden email] |     linux.conf.au 2014
                           | Come swan on the Swan River
                           |    http://linux.conf.au

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13.
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Davical-general mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/davical-general

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Reviewing status of Ján's patches

Hauke Fath
On Fri, 20 Sep 2013 23:21:17 +1200, Andrew Ruthven wrote:
> Right, no complaints, and Andrew M was happy, so I've just committed and
> pushed the outstanding patches to github.

After updating, I see a flood of

PHP Notice:  Use of undefined constant ENT_XML1 - assumed 'ENT_XML1' in
/usr/pkg/lib/php/awl/inc/XMLElement.php on line 267
PHP Notice:  Use of undefined constant ENT_DISALLOWED - assumed
'ENT_DISALLOWED' in /usr/pkg/lib/php/awl/inc/XMLElement.php on line 267

in the web server log.

I see that the constants have been added with php 5.4. Any workarounds
for php5.3.x, short of commenting out the flags?

hauke

--
     The ASCII Ribbon Campaign                    Hauke Fath
()     No HTML/RTF in email            Institut für Nachrichtentechnik
/\     No Word docs in email                     TU Darmstadt
     Respect for open standards              Ruf +49-6151-16-3281

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Davical-general mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/davical-general
Reply | Threaded
Open this post in threaded view
|

Re: Reviewing status of Ján's patches

Ján Máté-2
Hi Hauke,

you can remove this flag if you cannot upgrade to php 5.4 ... it fixes a rare bug when the server can generate invalid XML response (certain characters are invalid in XML 1.0 and this flag replaces these characters with U+FFFD).


JM


On Oct 8, 2013, at 5:05 PM, Hauke Fath <[hidden email]> wrote:

> On Fri, 20 Sep 2013 23:21:17 +1200, Andrew Ruthven wrote:
>> Right, no complaints, and Andrew M was happy, so I've just committed and
>> pushed the outstanding patches to github.
>
> After updating, I see a flood of
>
> PHP Notice:  Use of undefined constant ENT_XML1 - assumed 'ENT_XML1' in
> /usr/pkg/lib/php/awl/inc/XMLElement.php on line 267
> PHP Notice:  Use of undefined constant ENT_DISALLOWED - assumed
> 'ENT_DISALLOWED' in /usr/pkg/lib/php/awl/inc/XMLElement.php on line 267
>
> in the web server log.
>
> I see that the constants have been added with php 5.4. Any workarounds
> for php5.3.x, short of commenting out the flags?
>
> hauke
>
> --
>     The ASCII Ribbon Campaign                    Hauke Fath
> ()     No HTML/RTF in email            Institut für Nachrichtentechnik
> /\     No Word docs in email                     TU Darmstadt
>     Respect for open standards              Ruf +49-6151-16-3281
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
> _______________________________________________
> Davical-general mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/davical-general

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Davical-general mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/davical-general

smime.p7s (5K) Download Attachment